GH-148 Implement mentions system with @player detection and sound notifications by Copilot · Pull Request #208 · EternalCodeTeam/ChatFormatter

Copilot · 2026-02-07T10:16:11Z

Adds player mentions via @playername syntax with configurable sound notifications and per-player toggle controls.

Architecture

Core (chatformatter-core)

MentionDetector - Regex-based detection of @[a-zA-Z0-9_]{3,16} patterns, returns online players only
MentionService - Coordinates detection
MentionConfig - Config schema for sound type, volume, pitch, and default state
Extended ChatRenderedMessage record with List<Player> mentionedPlayers field
Extended ChatHandlerImpl.process() to detect mentions from raw message text

Paper Integration (chatformatter-paper-plugin)

MentionSoundHandler - Plays configured sound to mentioned players
Modified PaperChatEventExecutor to trigger sounds when mentionedPlayers is non-empty

Commands

Refactored ChatFormatterCommand with switch expression pattern for subcommands

Configuration

mentions:
  enabled: true
  sound: "BLOCK_NOTE_BLOCK_PLING"
  volume: 1.0
  pitch: 1.0

Usage

Player1: "Hey @Player2, check this out!"
// Player2 hears configured sound if enabled

Player2: "/chatformatter mentiontoggle"
// Toggles sound notifications

Testing

Unit tests cover detection patterns, online/offline filtering, and invalid usernames
CodeQL security scan: 0 alerts

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

hub.spigotmc.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Mentions system </issue_title>
<issue_description>Add a message system (/msg, /reply, /msgtoggle, /msgspy) including (if possible) a external placeholder for the msgtoggle status, i.e: (%chatformatter_mgstoggle% returns true/false)
for the format, it could be:
msgSender: To <recipient>: <message>
msgRecipient: From <sender>: <message>
Add mentions (@player), option to add sound when mention someone, and maybe a way to disable mention sounds (could be /mentiontoggle?)</issue_description>

<agent_instructions>Do not implement the messaging commands and placeholder. Focus only on the mentions, when someone types @player in chat they get a custom sound. You can also add the /mentiontoggle or /mentionsoundtoggle command.</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@CitralFlo The `/msg` command is a feature in EternalCore, so we suggest to use it, because of permissions and handling (`/msgtoggle`).
For the mention part I 100% approve :D</comment_new>

Fixes Mentions system #148

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>

# Conflicts: # build.gradle.kts # buildSrc/build.gradle.kts # chatformatter-paper-plugin/build.gradle.kts # gradle/wrapper/gradle-wrapper.properties

Jakubk15 · 2026-02-07T13:16:44Z

2026-02-07.14-04-35.mp4

Jakubk15 · 2026-02-07T13:18:17Z

this PR is bundled also with:

codestyle changes (thanks to my intellij)
Gradle update (we can now use Gradle 9.x configuration cache)
Enhanced Class Redefinition (aka enhanced hotswap)

Jakubk15 · 2026-02-07T13:18:43Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a well-structured player mention system with sound notifications. The separation of core logic, configuration, and the Paper-specific implementation is clean, and the inclusion of unit tests for the detection logic is a great practice.

However, there are a few discrepancies between the pull request description and the implemented code that should be addressed:

The /chatformatter mentiontoggle command and the associated per-player settings (mention-settings.yml, enabledByDefault config) are mentioned as part of this PR but have not been implemented. The command handler has been refactored to support subcommands, which is a good step, but only the reload command is present.
The filtering of self-mentions was also mentioned but is missing from the implementation. I've added a specific comment with a suggestion to fix this.

Overall, this is a solid foundation for the mentions feature. Addressing the missing pieces will bring it in line with the described functionality.

chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionDetector.java

…tion/MentionDetector.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

imDMK · 2026-02-07T21:31:28Z

chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java

 import java.util.Map;
+import java.util.Optional;
+
+import static net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer.legacySection;


We dont use static imports

imDMK · 2026-02-07T21:35:03Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionService.java

+        List<Player> players = detectMentions(message);
+        Sound sound = loadSound();
+
+        for (Player player : players) {
+            player.playSound(player.getLocation(), sound, config.mentions.volume, config.mentions.pitch);
+        }
+    }
+
+    private List<Player> detectMentions(String message) {
+        if (!this.config.mentions.enabled) {
+            return List.of();
+        }


Suggested change

List<Player> players = detectMentions(message);

Sound sound = loadSound();

for (Player player : players) {

player.playSound(player.getLocation(), sound, config.mentions.volume, config.mentions.pitch);

}

}

private List<Player> detectMentions(String message) {

if (!this.config.mentions.enabled) {

return List.of();

}

if (!this.config.mentions.enabled) {

return List.of();

}

List<Player> players = detectMentions(message);

Sound sound = loadSound();

for (Player player : players) {

player.playSound(player.getLocation(), sound, config.mentions.volume, config.mentions.pitch);

}

}

private List<Player> detectMentions(String message) {

imDMK · 2026-02-07T21:36:19Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionService.java

+    }
+
+    void mentionPlayers(String message) {
+        List<Player> players = detectMentions(message);


Suggested change

List<Player> players = detectMentions(message);

List<Player> mentionedPlayers = detectMentions(message);

CitralFlo

Few suggestions:

Add support for mentions without @ -> meaning entering a username in chat would ping the user
Make username mention configurable - so users can add hover or change the color of mentions in chat

Possible alternative:

Use packetEvents to support suggestions when user enters @ in chat
Move matcher logic to process only messages containing the @xxx - less work for the Service

CitralFlo · 2026-02-11T18:17:33Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionConfig.java

+@Contextual
+public class MentionConfig implements Serializable {
+
+    @Description({ " ", "# Mention system configuration" })


Suggested change

@Description({ " ", "# Mention system configuration" })

@Description("# Mention system configuration")

CitralFlo · 2026-02-11T18:17:50Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionConfig.java

+    @Description("# When a player mentions another player with @playername, the mentioned player will hear a sound")
+    public boolean enabled = true;
+
+    @Description({ " ", "# The sound to play when a player is mentioned" })


Suggested change

@Description({ " ", "# The sound to play when a player is mentioned" })

@Description("# The sound to play when a player is mentioned")

CitralFlo · 2026-02-11T18:18:03Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionConfig.java

+    @Description("# Available sounds: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Sound.html")
+    public String sound = "BLOCK_NOTE_BLOCK_PLING";
+
+    @Description({ " ", "# The volume of the mention sound (0.0 to 1.0)" })


Suggested change

@Description({ " ", "# The volume of the mention sound (0.0 to 1.0)" })

@Description("# The volume of the mention sound (0.0 to 1.0)")

CitralFlo · 2026-02-11T18:18:20Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionConfig.java

+    @Description({ " ", "# The volume of the mention sound (0.0 to 1.0)" })
+    public float volume = 1.0f;
+
+    @Description({ " ", "# The pitch of the mention sound (0.5 to 2.0)" })


Suggested change

@Description({ " ", "# The pitch of the mention sound (0.5 to 2.0)" })

@Description("# The pitch of the mention sound (0.5 to 2.0)")

CitralFlo · 2026-02-11T18:19:31Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionListener.java

+
+    @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR)
+    void onMention(AsyncPlayerChatEvent event) {
+        mentionService.mentionPlayers(event.getMessage());


Suggested change

mentionService.mentionPlayers(event.getMessage());

this.mentionService.mentionPlayers(event.getMessage());

CitralFlo · 2026-02-11T18:19:39Z

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionListener.java

+
+

Suggested change

CitralFlo · 2026-02-11T18:26:30Z

chatformatter-core/src/main/java/com/eternalcode/formatter/ChatFormatterPlugin.java

+
+        // Mentions
+        this.mentionService = new MentionService(server, pluginConfig);
+        server.getPluginManager().registerEvents(new MentionListener(mentionService), plugin);
+
+        // Update checker
        server.getPluginManager().registerEvents(new UpdaterController(updaterService, pluginConfig, audienceProvider, miniMessage), plugin);


Comments prbly not needed here

Jakubk15 and others added 2 commits August 31, 2025 19:54

Bump dependencies and Gradle

d17b275

Initial plan

2dbe929

Copilot AI assigned Copilot and Jakubk15 Feb 7, 2026

Copilot started work on behalf of Jakubk15 February 7, 2026 10:16 View session

Copilot AI and others added 4 commits February 7, 2026 10:19

Initial commit - planning mentions system implementation

a510853

Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>

Implement mentions system with @player detection and sound notifications

839a39f

Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>

Add tests and documentation for mentions feature

40b63ba

Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>

Address code review feedback - improve error handling and switch syntax

917834f

Co-authored-by: Jakubk15 <77227023+Jakubk15@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add mentions system with sound notification feature~~ Implement mentions system with @player detection and sound notifications Feb 7, 2026

Copilot AI requested a review from Jakubk15 February 7, 2026 10:28

Copilot finished work on behalf of Jakubk15 February 7, 2026 10:28

Jakubk15 added 4 commits February 7, 2026 13:05

Merge branch 'master' into update-gradle-and-deps

f030cd6

# Conflicts: # build.gradle.kts # buildSrc/build.gradle.kts # chatformatter-paper-plugin/build.gradle.kts # gradle/wrapper/gradle-wrapper.properties

fix: configuration cache errors related to runServer

1212723

Merge branch 'update-plugin-yml' into copilot/add-mentions-sound-feature

58ce9e9

feat: add mention sounds feature and improve configuration

04cff90

Jakubk15 marked this pull request as ready for review February 7, 2026 13:06

Jakubk15 added 2 commits February 7, 2026 14:14

Refactor placeholders format in README.md

b07f8f4

Update placeholders section in README.md

37a4da0

Jakubk15 requested review from CitralFlo, imDMK, noyzys and vLuckyyy February 7, 2026 13:19

Jakubk15 changed the title ~~Implement mentions system with @player detection and sound notifications~~ GH-148 Implement mentions system with @player detection and sound notifications Feb 7, 2026

gemini-code-assist bot reviewed Feb 7, 2026

View reviewed changes

chatformatter-core/src/main/java/com/eternalcode/formatter/ChatHandlerImpl.java Outdated Show resolved Hide resolved

chatformatter-core/src/main/java/com/eternalcode/formatter/mention/MentionDetector.java Outdated Show resolved Hide resolved

Update chatformatter-core/src/main/java/com/eternalcode/formatter/men…

64cb446

…tion/MentionDetector.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Jakubk15 added the 🆕 feature New feature or request label Feb 7, 2026

Jakubk15 removed their request for review February 7, 2026 13:24

Jakubk15 approved these changes Feb 7, 2026

View reviewed changes

Jakubk15 mentioned this pull request Feb 7, 2026

GH-173 Add MineDown support #209

Draft

Jakubk15 added 2 commits February 7, 2026 15:37

Revert reload command refactor

fe13db6

Revert code arrangement

59b2265

Rollczi force-pushed the copilot/add-mentions-sound-feature branch 10 times, most recently from 633bc02 to 94f4b86 Compare February 7, 2026 20:41

CR

5ac4ff7

Rollczi force-pushed the copilot/add-mentions-sound-feature branch from 94f4b86 to 5ac4ff7 Compare February 7, 2026 20:41

Rollczi approved these changes Feb 7, 2026

View reviewed changes

imDMK requested changes Feb 7, 2026

View reviewed changes

CitralFlo requested changes Feb 11, 2026

View reviewed changes

	List<Player> players = detectMentions(message);
	List<Player> mentionedPlayers = detectMentions(message);

	@Description({ " ", "# Mention system configuration" })
	@Description("# Mention system configuration")

	@Description({ " ", "# The sound to play when a player is mentioned" })
	@Description("# The sound to play when a player is mentioned")

	@Description({ " ", "# The volume of the mention sound (0.0 to 1.0)" })
	@Description("# The volume of the mention sound (0.0 to 1.0)")

	@Description({ " ", "# The pitch of the mention sound (0.5 to 2.0)" })
	@Description("# The pitch of the mention sound (0.5 to 2.0)")

	mentionService.mentionPlayers(event.getMessage());
	this.mentionService.mentionPlayers(event.getMessage());

Uh oh!

Conversation

Copilot AI commented Feb 7, 2026 • edited by Jakubk15 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Architecture

Configuration

Usage

Testing

I tried to connect to the following addresses, but was blocked by firewall rules:

Comments on the Issue (you are @copilot in this section)

Uh oh!

Jakubk15 commented Feb 7, 2026

Uh oh!

Jakubk15 commented Feb 7, 2026

Uh oh!

Jakubk15 commented Feb 7, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CitralFlo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Feb 7, 2026 •

edited by Jakubk15

Loading